Re: [PATCH -next v2 1/3] staging: rtl8192e: rtl_core: Call dev_kfree_skb_irq() instead of kfree_skb() under spin_lock_irqsave()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Jinjie Ruan <ruanjinjie@xxxxxxxxxx>
Subject: Re: [PATCH -next v2 1/3] staging: rtl8192e: rtl_core: Call dev_kfree_skb_irq() instead of kfree_skb() under spin_lock_irqsave()
From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 13 Sep 2023 10:34:23 +0200
Cc: philipp.g.hortmann@xxxxxxxxx, straube.linux@xxxxxxxxx, Larry.Finger@xxxxxxxxxxxx, wlanfae@xxxxxxxxxxx, mikem@xxxxxxxxxx, seanm@xxxxxxxx, linux-staging@xxxxxxxxxxxxxxx
In-reply-to: <20230825015213.2697347-2-ruanjinjie@huawei.com>
References: <20230825015213.2697347-1-ruanjinjie@huawei.com> <20230825015213.2697347-2-ruanjinjie@huawei.com>

On Fri, Aug 25, 2023 at 09:52:11AM +0800, Jinjie Ruan wrote:
> It is not allowed to call kfree_skb() from hardware interrupt
> context or with hardware interrupts being disabled.

Why not?  Seems to work so far :)

Are you fixing up all of the normal network drivers for this first?

thanks,

greg k-h

Follow-Ups:
- Re: [PATCH -next v2 1/3] staging: rtl8192e: rtl_core: Call dev_kfree_skb_irq() instead of kfree_skb() under spin_lock_irqsave()
  - From: Ruan Jinjie

References:
- [PATCH -next v2 0/3] staging: rtl8192e: Do not call kfree_skb() under spin_lock_irqsave()
  - From: Jinjie Ruan
- [PATCH -next v2 1/3] staging: rtl8192e: rtl_core: Call dev_kfree_skb_irq() instead of kfree_skb() under spin_lock_irqsave()
  - From: Jinjie Ruan

Prev by Date: Re: [PATCH 2/2] staging: vme_user: Fix block comments where '*' on each line should be aligned
Next by Date: Re: [PATCH v10 1/5] staging: vc04_services: vchiq_arm: Add new bus type and device type
Previous by thread: [PATCH -next v2 1/3] staging: rtl8192e: rtl_core: Call dev_kfree_skb_irq() instead of kfree_skb() under spin_lock_irqsave()
Next by thread: Re: [PATCH -next v2 1/3] staging: rtl8192e: rtl_core: Call dev_kfree_skb_irq() instead of kfree_skb() under spin_lock_irqsave()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Driver Development] [Linux Driver Backports] [DMA Engine] [Linux GPIO] [Linux SPI] [Video for Linux] [Linux USB Devel] [Linux Coverity] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]