On Mon, Aug 28, 2023 at 04:38:32PM +0200, Nam Cao wrote: > On Mon, Aug 28, 2023 at 09:39:14AM -0400, Oliver Crumrine wrote: > > Make the octeon ethernet driver better adhere to the > > kernel coding standard > > > > Signed-off-by: Oliver Crumrine <ozlinux@xxxxxxxxxxx> > > --- > > v2: Actually send the patch set properly > > v3: Fixed a bug where I forgot to change all instances of a struct > > v4: Actually fix that bug (this is my first patch, give me a break) > > Don't give up! You will get it right eventually. > > This is not important, but I prefer you revert the order of the change log. > The changes compared to the last version is most relevant, so preferably they > should be put on top. Either way is fine, this isn't an issue. What _is_ an issue is that all of these have the identical subject line, and the identical changelog text _yet_ they do different things. Oliver, please read read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for a description of how to do properly. thanks, greg k-h
