Hi Oliver, kernel test robot noticed the following build warnings: [auto build test WARNING on staging/staging-testing] url: https://github.com/intel-lab-lkp/linux/commits/Oliver-Crumrine/staging-octeon-clean-up-the-octeon-ethernet-driver/20230828-080105 base: staging/staging-testing patch link: https://lore.kernel.org/r/PH7PR11MB764329EC8CFB56ABFA7A8D77BCE1A%40PH7PR11MB7643.namprd11.prod.outlook.com patch subject: [PATCH v3 6/6] staging: octeon: clean up the octeon ethernet driver config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230828/202308281043.2o6mVbgk-lkp@xxxxxxxxx/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce: (https://download.01.org/0day-ci/archive/20230828/202308281043.2o6mVbgk-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202308281043.2o6mVbgk-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): drivers/staging/octeon/ethernet.c: In function 'cvm_oct_common_get_stats': drivers/staging/octeon/ethernet.c:204:39: error: storage size of 'rx_status' isn't known 204 | struct cvmx_pip_port_status_t rx_status; | ^~~~~~~~~ In file included from include/linux/string.h:254, from include/linux/bitmap.h:11, from include/linux/cpumask.h:12, from arch/x86/include/asm/paravirt.h:17, from arch/x86/include/asm/irqflags.h:60, from include/linux/irqflags.h:17, from include/linux/rcupdate.h:26, from include/linux/rculist.h:11, from include/linux/pid.h:5, from include/linux/sched.h:14, from include/linux/ratelimit.h:6, from include/linux/dev_printk.h:16, from include/linux/device.h:15, from include/linux/platform_device.h:13, from drivers/staging/octeon/ethernet.c:8: >> include/linux/fortify-string.h:515:65: warning: left-hand operand of comma expression has no effect [-Wunused-value] 515 | fortify_memset_chk(__fortify_size, p_size, p_size_field), \ | ^ include/linux/fortify-string.h:524:25: note: in expansion of macro '__fortify_memset_chk' 524 | #define memset(p, c, s) __fortify_memset_chk(p, c, s, \ | ^~~~~~~~~~~~~~~~~~~~ drivers/staging/octeon/ethernet.c:211:25: note: in expansion of macro 'memset' 211 | memset(&rx_status, 0, sizeof(rx_status)); | ^~~~~~ >> drivers/staging/octeon/ethernet.c:204:39: warning: unused variable 'rx_status' [-Wunused-variable] 204 | struct cvmx_pip_port_status_t rx_status; | ^~~~~~~~~ vim +/rx_status +204 drivers/staging/octeon/ethernet.c 195 196 /** 197 * cvm_oct_common_get_stats - get the low level ethernet statistics 198 * @dev: Device to get the statistics from 199 * 200 * Returns Pointer to the statistics 201 */ 202 static struct net_device_stats *cvm_oct_common_get_stats(struct net_device *dev) 203 { > 204 struct cvmx_pip_port_status_t rx_status; 205 cvmx_pko_port_status_t tx_status; 206 struct octeon_ethernet *priv = netdev_priv(dev); 207 208 if (priv->port < CVMX_PIP_NUM_INPUT_PORTS) { 209 if (octeon_is_simulation()) { 210 /* The simulator doesn't support statistics */ 211 memset(&rx_status, 0, sizeof(rx_status)); 212 memset(&tx_status, 0, sizeof(tx_status)); 213 } else { 214 cvmx_pip_get_port_status(priv->port, 1, &rx_status); 215 cvmx_pko_get_port_status(priv->port, 1, &tx_status); 216 } 217 218 dev->stats.rx_packets += rx_status.inb_packets; 219 dev->stats.tx_packets += tx_status.packets; 220 dev->stats.rx_bytes += rx_status.inb_octets; 221 dev->stats.tx_bytes += tx_status.octets; 222 dev->stats.multicast += rx_status.multicast_packets; 223 dev->stats.rx_crc_errors += rx_status.inb_errors; 224 dev->stats.rx_frame_errors += rx_status.fcs_align_err_packets; 225 dev->stats.rx_dropped += rx_status.dropped_packets; 226 } 227 228 return &dev->stats; 229 } 230 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
