Hi,
On 8/13/23 17:26, Hans de Goede wrote:
> ov5693 sensor modules have a VCM, but for unknown reasons
> the sensor fails to start streaming when instantiating
> a VCM i2c-client (and the runtime-pm link between VCM
> and sensor).
>
> Disable the VCM for now, until this is resolved.
>
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
Note I have applied this series and 3 other pending atomisp patches from me to my media-atomisp branch now.
Sorry for not giving any time for review, but I believe these to be obviously correct (or at least the right thing to do for now for 1/2) and I'm preparing my media-atomisp branch to send a pull-req to Mauro for the upcoming 6.6 cycle.
Regards,
Hans
> ---
> drivers/staging/media/atomisp/pci/atomisp_csi2_bridge.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_csi2_bridge.c b/drivers/staging/media/atomisp/pci/atomisp_csi2_bridge.c
> index 03940c11505f..2483eaeeac73 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_csi2_bridge.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_csi2_bridge.c
> @@ -521,7 +521,12 @@ static char *atomisp_csi2_get_vcm_type(struct acpi_device *adev)
> }
>
> static const struct acpi_device_id atomisp_sensor_configs[] = {
> - ATOMISP_SENSOR_CONFIG("INT33BE", 2, true), /* OV5693 */
> + /*
> + * FIXME ov5693 modules have a VCM, but for unknown reasons
> + * the sensor fails to start streaming when instantiating
> + * an i2c-client for the VCM, so it is disabled for now.
> + */
> + ATOMISP_SENSOR_CONFIG("INT33BE", 2, false), /* OV5693 */
> {}
> };
>
