Re: [PATCH -next] staging: ks7010: remove unnecessary sdio_set_drvdata() function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 11, 2023 at 05:17:36PM +0800, Yang Yingliang wrote:
> The driver data will be cleared in device_unbind_cleanup() in driver
> core code. So the sdio_set_drvdata(..., NULL) called in remove and
> error path in probe can be removed.

Yes, but, many things happen after the remove function is called and the
driver core cleans up that field, so are you SURE that it is safe to
make these kinds of changes?

How have you tested all of these?

thanks,

greg k-h




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux