Re: [PATCH v2] staging: vme_user: fix check alignment should match open parenthesis

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 04, 2023 at 03:23:17PM +0200, Greg KH wrote:
> On Tue, Aug 01, 2023 at 01:17:07PM -0300, Alexon Oliveira wrote:
> > First patch was intended to fix all "CHECK: Alignment should match open parenthesis",
> > but added new warnings in the process. This patch is intended to fixed them all,
> > on lines 133, 142, 144, 145 and 173.
> 
> Patches are stand-alone, we have no idea what "First patch" is.
>

That was just me being verbose and given more details related to the
v1 of this patch. I apologize. Nevermind that. What is worth is below
the ---

> Please look at the commit log for this file, or for all of
> drivers/staging:
> 	git log drivers/staging/
> and get an idea of what changelog text should look like.
> 

ACK. So the correct changelog should be:

staging: vme_user: fix check alignment should match open parenthesis

Fixed the following as reported by checkpatch to adhere to the
Linux kernel coding-style guidelines.

Changes in v2:
- Fixed CHECK: line length exceeds 100 columns, noted by Greg KH and Dan Carpenter
- Fixed CHECK: Alignment should match open parenthesis
- Fixed CHECK: Lines should not end with a '('

Changes in v1:
- Fixed CHECK: Alignment should match open parenthesis

Signed-off-by: Alexon Oliveira <alexondunkan@xxxxxxxxx>

> 
> thanks,
> 
> greg k-h

Thank you.

Alexon Oliveira




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux