>From 15487baaf86627009a06ab5217428d3b29028c32 Mon Sep 17 00:00:00 2001 From: Pavan Bobba <opensource206@xxxxxxxxx> Date: Wed, 2 Aug 2023 18:12:56 +0530 Subject: [PATCH v2] staging: vt6655: replace camel case by snake case Replace array name of camel case by snake case. Issue found by checkpatch Signed-off-by: Pavan Bobba <opensource206@xxxxxxxxx> --- v1 -> v2: added '_' in between by and vt3253 in array name "byvt3253b0_rfmd" and replaced the word "small case" with "snake case" in the mail description drivers/staging/vt6655/baseband.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c index 0e135af8316b..8b913c64845c 100644 --- a/drivers/staging/vt6655/baseband.c +++ b/drivers/staging/vt6655/baseband.c @@ -499,7 +499,7 @@ static const unsigned char by_vt3253_init_tab_rfmd[CB_VT3253_INIT_FOR_RFMD][2] = }; #define CB_VT3253B0_INIT_FOR_RFMD 256 -static const unsigned char byVT3253B0_RFMD[CB_VT3253B0_INIT_FOR_RFMD][2] = { +static const unsigned char byvt3253b0_rfmd[CB_VT3253B0_INIT_FOR_RFMD][2] = { {0x00, 0x31}, {0x01, 0x00}, {0x02, 0x00}, @@ -2005,8 +2005,8 @@ bool bb_vt3253_init(struct vnt_private *priv) } else { for (ii = 0; ii < CB_VT3253B0_INIT_FOR_RFMD; ii++) result &= bb_write_embedded(priv, - byVT3253B0_RFMD[ii][0], - byVT3253B0_RFMD[ii][1]); + byvt3253b0_rfmd[ii][0], + byvt3253b0_rfmd[ii][1]); for (ii = 0; ii < CB_VT3253B0_AGC_FOR_RFMD2959; ii++) result &= bb_write_embedded(priv, -- 2.34.1 On Wed, Aug 02, 2023 at 04:33:24PM +0300, Dan Carpenter wrote: > On Wed, Aug 02, 2023 at 06:56:35PM +0530, Pavan Bobba wrote: > > Replace array name of camel case by small case. Issue found > > by checkpatch > > > > Signed-off-by: Pavan Bobba <opensource206@xxxxxxxxx> > > --- > > drivers/staging/vt6655/baseband.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c > > index 0e135af8316b..8b913c64845c 100644 > > --- a/drivers/staging/vt6655/baseband.c > > +++ b/drivers/staging/vt6655/baseband.c > > @@ -499,7 +499,7 @@ static const unsigned char by_vt3253_init_tab_rfmd[CB_VT3253_INIT_FOR_RFMD][2] = > > }; > > > > #define CB_VT3253B0_INIT_FOR_RFMD 256 > > -static const unsigned char byVT3253B0_RFMD[CB_VT3253B0_INIT_FOR_RFMD][2] = { > > +static const unsigned char byvt3253b0_rfmd[CB_VT3253B0_INIT_FOR_RFMD][2] = { > > The one before it is called something liek by_vt3253b0_rfmd. > > I don't know what by_ or bb_ meant to the driver authors so I can't say > if that's a good name, but lets at least keep it consistent and put an > underscore between by and vt, by_vt. > > regards, > dan carpenter >