On Thu, Jul 20, 2023 at 09:10:33AM +0200, Uwe Kleine-König wrote: > Hello Thierry, > > On Thu, Jul 20, 2023 at 08:48:11AM +0200, Thierry Reding wrote: > > On Fri, Jul 14, 2023 at 10:56:13PM +0200, Uwe Kleine-König wrote: > > > Uwe Kleine-König (10): > > > pwm: Use a consistent name for pwm_chip pointers in the core > > > pwm: atmel-hlcdc: Use consistent variable naming > > > pwm: bcm-kona: Consistenly name pwm_chip variables "chip" > > > pwm: crc: Consistenly name pwm_chip variables "chip" > > > pwm: cros-ec: Consistenly name pwm_chip variables "chip" > > > pwm: lp3943: Consistenly name pwm_chip variables "chip" > > > pwm: rockchip: Consistenly name pwm_chip variables "chip" > > > pwm: sifive: Consistenly name pwm_chip variables "chip" > > > pwm: sl28cpld: Consistenly name pwm_chip variables "chip" > > > staging: greybus: pwm: Consistenly name pwm_chip variables "chip" > > > > This would've been much easier if it had been a single patch. Now I have > > to either make you redo the whole series because you've misspelled PWM > > or I have to go and update it myself in most of the above patches. Hint: > > I'll do the latter. > > I guess you want to do s/pwm driver/PWM driver/? Fine for me, thanks. > > > There is really no reason to split this up into this many patches for > > such a trivial change. > > Well, that's a subjective view. There are reasons to prefer several > small patches over one big one, too. A small patch can be indiviually > reviewed, so the "Reviewed-by: Alex Elder ..." tag only goes to the one > change that he actually looked at and if later a fix to the sifive > driver is to be backported to stable, the stable maintainers just pick > the sifive one instead of one big patch. Backports becoming more complicated would actually be a good reason not to do this in the first place, but we've already discussed that enough elsewhere. > Did you skip the sl28cpld patch, or squash the fixup I sent in the reply > to Michael Walle? I squashed the fixup. Thierry
Attachment:
signature.asc
Description: PGP signature
