Re: [PATCH 00/11] #if defined(ISP2401) removal to make driver generic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hans

On Fri, Jul 14, 2023 at 3:38 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>
> Hi Kate,
>
> On 7/13/23 12:02, Kate Hsuan wrote:
> > This patch set is to remove #if defined(ISP2401) to make the driver
> > generic. We focused on removing the #if defined(ISP2401) in isys and
> > necessary files related to it.
> >
> > The changes include:
> > 1. Removed #if defined(ISP2401) in isys and related directories.
> > 2. Removed the debug codes for dumping status.
> > 3. Made two individual enum to define the MIPI format for both types of
> >    atomisp.
> > 4. The input system code should include both input system (ISP2400 and
> >    ISP2401) headers since a generic driver should cover all types
> >    of devcices.
> > 5. The initialization codes of the input system was modified to initiate
> >    atomisp input system in a generic manner.
>
> Thank you very much for all your hard work on this.
>
> The entire series looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
>
> for the series. I'll merge this into my media-atomisp branch
> when I can make some time to do so.
>

Thank you for reviewing

> Regards,
>
> Hans
>
>
>
> >
> >
> > Kate Hsuan (11):
> >   media: atomisp: ia_css_debug: Removed debug codes for dumping status
> >   media: atomisp: Make two individual enum to define the MIPI format
> >   media: atomisp: Included both input system headers
> >   media: atomisp: css_2401_system: Remove #ifdef ISP2401 to make the
> >     driver generic
> >   media: atomisp: isys: Removed #if defined(ISP2401) to make driver
> >     generic
> >   media: atomisp: hive_isp_css_common: Removed #if defined(ISP2401) to
> >     make driver generic
> >   media: atomisp: pipeline: Removed #if defined(ISP2401) to make driver
> >     generic
> >   media: atomisp: ifmtr: Removed #if defined(ISP2401) to make driver
> >     generic
> >   media: atomisp: Compile the object codes for a generic driver
> >   media: atomisp: rx: Removed #if defined(ISP2401) to make driver
> >     generic
> >   media: atomisp: isys_init: Initiate atomisp in a generic manner
> >
> >  drivers/staging/media/atomisp/Makefile        |  12 +-
> >  .../pci/css_2401_system/host/isys_irq_local.h |   3 -
> >  .../css_2401_system/host/isys_irq_private.h   |   2 -
> >  .../pci/css_2401_system/isys_irq_global.h     |   2 -
> >  .../host/input_formatter.c                    |   2 -
> >  .../hive_isp_css_common/host/input_system.c   |  75 -----
> >  .../host/isys_dma_public.h                    |   2 -
> >  .../host/isys_irq_public.h                    |   2 -
> >  .../hive_isp_css_include/host/isys_public.h   |  19 --
> >  .../pci/hive_isp_css_include/isys_irq.h       |   2 -
> >  .../media/atomisp/pci/input_system_local.h    |   7 +-
> >  .../media/atomisp/pci/input_system_private.h  |   7 +-
> >  .../media/atomisp/pci/input_system_public.h   |   4 +-
> >  .../atomisp/pci/isp2400_input_system_local.h  |  89 +++---
> >  .../pci/isp2400_input_system_private.h        |   4 +-
> >  .../atomisp/pci/isp2400_input_system_public.h |  13 +-
> >  .../atomisp/pci/isp2401_input_system_local.h  |  88 +++---
> >  .../pci/isp2401_input_system_private.h        | 112 +-------
> >  .../runtime/debug/interface/ia_css_debug.h    |   6 -
> >  .../pci/runtime/debug/src/ia_css_debug.c      | 256 ------------------
> >  .../atomisp/pci/runtime/ifmtr/src/ifmtr.c     |   2 -
> >  .../pci/runtime/isys/interface/ia_css_isys.h  |   9 +-
> >  .../runtime/isys/interface/ia_css_isys_comm.h |   2 -
> >  .../pci/runtime/isys/src/csi_rx_rmgr.c        |   2 -
> >  .../pci/runtime/isys/src/isys_dma_rmgr.c      |   2 -
> >  .../atomisp/pci/runtime/isys/src/isys_init.c  |  31 +--
> >  .../runtime/isys/src/isys_stream2mmio_rmgr.c  |   2 -
> >  .../media/atomisp/pci/runtime/isys/src/rx.c   | 227 ++++++++++------
> >  .../pci/runtime/isys/src/virtual_isys.c       |   8 +-
> >  .../pipeline/interface/ia_css_pipeline.h      |   2 -
> >  .../pci/runtime/pipeline/src/pipeline.c       |   2 -
> >  drivers/staging/media/atomisp/pci/sh_css.c    |   2 -
> >  drivers/staging/media/atomisp/pci/sh_css_sp.c |   2 -
> >  drivers/staging/media/atomisp/pci/sh_css_sp.h |   2 -
> >  34 files changed, 253 insertions(+), 749 deletions(-)
> >
>


-- 
BR,
Kate






[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux