On 6/28/23 18:38, Franziska Näpelt wrote:
Hi Philipp,
Am Mo., 26. Juni 2023 um 19:09 Uhr schrieb Philipp Hortmann
<philipp.g.hortmann@xxxxxxxxx>:
On 6/25/23 17:56, Franziska Naepelt wrote:
This is a series of patches to fix some trivial checkpatch issues. Not all
issues have been fixed. I intend to submit another series to fix more stuff.
Testing:
---
v3: Series to contain only remaining patches.
Franziska Naepelt (3):
staging: rtl8723bs: Fix space issues
staging: rtl8723bs: Fix alignment open parenthesis
staging: rtl8723bs: Fix remaining blank line issue
.../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 164 +++++++++---------
1 file changed, 85 insertions(+), 79 deletions(-)
--
2.39.2 (Apple Git-143)
checkpatch prints the following warning:
WARNING: From:/Signed-off-by: email address mismatch: 'From: Franziska
Naepelt <franziska.naepelt@xxxxxxxxxxxxxx>' != 'Signed-off-by: Franziska
Naepelt <franziska.naepelt@xxxxxxxxx>'
I propose you change the git email matching the one that you use to send.
When testing you can compile the driver with this command:
make -C . M=drivers/staging/rtl8723bs
Typically a compile of the entire kernel is not required.
Please use the subsystem and driver also for the Subject line of the
cover letter.
Bye Philipp
Do you want me to submit v4 to fix the email address as well as the subject of
the cover letter or are you ok with me promising to make it properly the next
time? ;)
Thanks,
Franziska
Hi Franziska,
you do not need to submit v4 for me.
Here the reason what you need to take into account.
If you leave the e-mail addresses this way you need to monitor both for
the next weeks. Because somebody(or a robot) may contact you for
questions, errors or hints for improvement.
If you look into the kernel patch statistics:
http://www.remword.com/kps_result/all_petop.html
Look in google for: "kernel patch statistics"
You can find this person:
Franziska Naepelt <franziska ! naepelt () idt ! com>
1(0.00%) @IDT @Unknown
May be this is you. Maybe you want to see the number of patches in total
that you have submitted. That is best possible if you submit all patches
under one Email address.
May be you plan to vote for the Technical Advisory Board. Then you need
to collect your patches (credits under one email address)
So all your choice.
Bye Philipp
