On Wed, Jun 07, 2023 at 10:18:28PM +0200, Philipp Hortmann wrote: > On 6/7/23 17:07, Dan Carpenter wrote: > > On Wed, Jun 07, 2023 at 08:31:41PM +0530, Yogesh Hegde wrote: > > > The variable SetWirelessMode is set in only one place throughout the > > > driver. This patch removes the variable and calls the real function > > > directly instead, eliminating the unnecessary indirection. > > > Additionally, the removal of the variable aligns with the checkpatch > > > guidelines by removing the use of CamelCase. > > > > > > Signed-off-by: Yogesh Hegde <yogi.kernel@xxxxxxxxx> > > > --- > > > > > > v2: Removed the variable and called the function direction instead of > > > just renaming the variable as suggested by Greg Kroah-Hartman > > > <gregkh@xxxxxxxxxxxxxxxxxxx>. > > > > Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > > > regards, > > dan carpenter > > > > > > Hi Dan, > > thanks for all the work you do. I always appreciate your comments. > No need to butter me up. :P > But I think it does not work because this driver is divided into two > modules. > Yeah, you're right. I'm wrong. We can't break the compile. regards, dan carpenter
