Hi Andy, On 6/4/23 21:28, Andy Shevchenko wrote: > On Sun, Jun 4, 2023 at 7:14 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: >> >> Hi All, >> >> Here is some more ov2680 sensor driver work. This work is the result >> of trying to get the main drivers/media/i2c/ov2680.c driver in a shape >> where it is good enough to replace the atomisp specific version. >> >> The plan is to port recent improvements to atomisp-ov2680.c over >> to the main driver. While working on this I noticed some issues which >> need fixing before copying them over to the "main" driver. >> >> Besides that this also adds a small patch to make testing with >> gstreamer easier and this adds testing instruction to the TODO file. > > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > (a nit-pick in one patch commented separately) > > Thank you! Thank you for the reviews. I've pushed this series (with the nitpick addressed) as well as the previous 3 fixes you reviewed to my media-atomisp branch now. Regards, Hans >> Hans de Goede (5): >> media: atomisp: Stop resetting selected input to 0 between /dev/video# >> opens >> media: atomisp: ov2680: Stop using half pixelclock for binned modes >> media: atomisp: ov2680: Remove unnecessary registers from >> ov2680_global_setting[] >> media: atomisp: ov2680: Rename unknown/0x370a to sensor_ctrl_0a >> media: atomisp: Add testing instructions to TODO file >> >> drivers/staging/media/atomisp/TODO | 33 +++++ >> .../media/atomisp/i2c/atomisp-ov2680.c | 15 +-- >> drivers/staging/media/atomisp/i2c/ov2680.h | 118 +++++++++--------- >> .../staging/media/atomisp/pci/atomisp_fops.c | 3 - >> 4 files changed, 95 insertions(+), 74 deletions(-) >> >> -- >> 2.40.1 >> > >
