Hi, On 5/30/23 13:58, Andy Shevchenko wrote: > On Tue, May 30, 2023 at 12:05 AM Andy Shevchenko > <andy.shevchenko@xxxxxxxxx> wrote: >> On Mon, May 29, 2023 at 1:38 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > A couple of additional comments (based on the branch contents). > > ... > >>> 2. atomisp_set_fmt() starts with basically an atomisp_try_fmt() call, >>> except that the only atomisp_try_fmt() caller: atomisp_try_fmt_cap() >>> adds the sensor padding itself rather then letting atomisp_try_fmt() > > than > >>> do this (duplication). > > ... > >> bytes = DIV_ROUND_UP(br_fmt->depth * width, BITS_PER_BYTE); > > It's actually NIH BITS_TO_BYTES() from bitops.h. Thank you, both are fixed in my media-atomisp branch now. Regards, Hans
