Hi, On 5/29/23 22:57, Andy Shevchenko wrote: > On Mon, May 29, 2023 at 1:38 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: >> >> Factor the code to go from width to a properly aligned pitch out of >> ia_css_frame_info_set_width(). >> >> This is a preparation patch to fix try_fmt() calls returning a bogus >> bytesperline value. > > ... > >> + /* >> + * frames with a U and V plane of 8 bits per pixel need to have > > Frames > >> + * all planes aligned, this means double the alignment for the >> + * Y plane if the horizontal decimation is 2. >> + */ >> + if (format == IA_CSS_FRAME_FORMAT_YUV420 || >> + format == IA_CSS_FRAME_FORMAT_YV12 || >> + format == IA_CSS_FRAME_FORMAT_NV12 || >> + format == IA_CSS_FRAME_FORMAT_NV21 || >> + format == IA_CSS_FRAME_FORMAT_BINARY_8 || >> + format == IA_CSS_FRAME_FORMAT_YUV_LINE) >> + return CEIL_MUL(width, 2 * HIVE_ISP_DDR_WORD_BYTES); > >> + else if (format == IA_CSS_FRAME_FORMAT_NV12_TILEY) >> + return CEIL_MUL(width, NV12_TILEY_TILE_WIDTH); >> + else if (format == IA_CSS_FRAME_FORMAT_RAW || >> + format == IA_CSS_FRAME_FORMAT_RAW_PACKED) >> + return CEIL_MUL(width, 2 * ISP_VEC_NELEMS); >> + else > > All 'else':s can be dropped. Actually the whole function is really just a single switch-case, so I've switched to that since that is even better IMHO. Regards, Hans > >> + return CEIL_MUL(width, HIVE_ISP_DDR_WORD_BYTES); >> +} >
