On Mon, May 29, 2023 at 1:38 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > A lot of work has been done on the atomisp driver lately. > > Rewrite the TODO file to drop all the already fixed items: > > * Moved to videobuf2 + fixed mmap support > * Whole bunch of v4l2 API fixes making more apps work > * v4l2-async sensor probing support > * pm-runtime support (for some sensor drivers at least) > * buffer MM code was cleaned up / replaced when moving the videobuf2 > > And add a new TODO list (retaining some of the old items) split > into items which absolutely must be fixed before the driver can > be moved out of staging: > > 1. Conflicting hw-ids with regular sensor drivers > 2. Private userspace API stuff > > As well as a list of items which also definitely needs to be fixed > but which could also be fixed after moving the driver out of staging. ... > +Required firmware > +================= > > +The atomisp driver requires the following firmware: > > +- for BYT: /lib/firmware/shisp_2400b0_v21.bin > + > + With a version of "irci_stable_candrpv_0415_20150423_1753" to check > + the version run: "strings shisp_2400b0_v21.bin | head -n1" . > + > + The shisp_2400b0_v21.bin file with this version can be found on > + the Android factory images of various X86 Android tablets such as > + e.g. the Chuwi Hi8 Pro. > > - for CHT: /lib/firmware/shisp_2401a0_v21.bin > > + With a version of "irci_stable_candrpv_0415_20150521_0458" > + > + This can be found here: > https://github.com/intel-aero/meta-intel-aero-base/blob/master/recipes-kernel/linux/linux-yocto/shisp_2401a0_v21.bin Can you add md5/SHA-1/SHA-256 sum(s) for the firmwares? ... > +1. items which MUST be fixed before the driver can be moved out of staging: Items ... > +* Remove/disable private ioctls IOCTLs ... > +* Without a 3A library the capture behaviour is not very good. To take a good > + picture, the exposure/gain needs to be tuned using v4l2-ctl on the sensor > + subdev. To fix this support for the atomisp needs to be added to libcamera. this, support ... > + This MUST be done before moving the driver out of staging so that we can > + still make changes to e.g. the mediactl topology if necessary for > + libcamera integration. Since this would be a userspace API break this break, this > + means that at least proof-of-concept libcamera integration needs to be > + ready before moving the driver out of staging. ... > +2. items which SHOULD also be fixed eventually: Items -- With Best Regards, Andy Shevchenko
