On Thu, May 04, 2023 at 09:28:44PM +0800, Dongliang Mu wrote: > Hi maintainers, > > In r8712_createbss_cmd(), there are two redundant assignments [1][2]. > > pdev_network->IELength = pdev_network->IELength; > pdev_network->Ssid.SsidLength = pdev_network->Ssid.SsidLength; > > However, I am not sure how to write a patch to fix this issue. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/staging/rtl8712/rtl871x_cmd.c#n333 > > [2] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/staging/rtl8712/rtl871x_cmd.c#n334 > That comes from commit 0f11b53dbc69 ("staging:rtl8712: Fix sparse warning incorrect type in assignment"). The commit is clearly wrong, but you'd have to check what the proper endianness is supposed to be. regards, dan carpenter
