Re: [PATCH v5 0/4] Remove unused rf_set_sens variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/24/23 20:03, Yogesh Hegde wrote:
The rf_set_sens variable is declared but never set, so it is always NULL.
Cleanup the unused rf_set_sens variable. Remove functions
_rtl92e_wx_get_sens and _rtl92e_wx_set_sens which always returned
error code after removal of rf_set_sens variable.
Cleanup unused max_sens and sens variable.
The patches are required to be applied in sequence.

Changes in v5:
     1. Rebased onto latest staging-testing branch per feedback from
        philipp.g.hortmann@xxxxxxxxx

Changes in v4:
     1. Split changes into patch series per feedback from
        gregkh@xxxxxxxxxxxxxxxxxxx

Changes in v3:
     1. Fixed description to fit within 75 chars
     2. Added suggested tags
     per feedback from philipp.g.hortmann@xxxxxxxxx

Changes in v2:
     1. Removed function definition rf_set_sens
     2. Removed usage of variable priv->rf_set_sens
     3. Removed functions _rtl92e_wx_get_sens and _rtl92e_wx_set_sens
     4. Cleaned up the variables sens and max_sens used in these functions

Changes in v1:
     1. Fix comparison to NULL of variable rf_set_sens

Yogesh Hegde (4):
   staging: rtl8192e: Remove unused rf_set_sens variable
   staging: rtl8192e: Remove unused _rtl92e_wx_get_sens function
   staging: rtl8192e: Remove unused _rtl92e_wx_set_sens function
   staging: rtl8192e: Remove unused sens and max_sens from r8192_priv
     struct

  drivers/staging/rtl8192e/rtl8192e/rtl_core.h |  3 --
  drivers/staging/rtl8192e/rtl8192e/rtl_wx.c   | 45 --------------------
  2 files changed, 48 deletions(-)


Tested-by: Philipp Hortmann <philipp.g.hortmann@xxxxxxxxx>





[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux