On Sat, Apr 15, 2023 at 04:10:44PM +0200, Luke Koch wrote: > + for (int i = 0; i < 8; i++) { > + if (count > i && > + DOT11_RATE5_ISBASIC_GET(item->supprates[i])) { > + req->basicrate[i] .data = item->supprates[i]; ^ Could you remove these spaces before the .data and .status? Otherwise it looks good to me. Reviewed-by: Dan Carpenter <error27@xxxxxxxxx> regards, dan carpenter