Re: [PATCH] staging: greybus: drop loopback test files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/6/23 3:18 AM, Greg Kroah-Hartman wrote:
The greybus loopback test tool does not belong burried down in a
driver-specific directory.  If it is needed, it should be somewhere
else, like in the testing directory.  But as the loopback driver is
probably never going to be merged out of the staging directory, let's
just delete the test alltogether for now.  If it's needed in the future,
it can be brought back with a revert.

Also, having an Android.mk file in the kernel source tree breaks some
Android build systems when trying to build from a read-only source tree,
the report of which prompted this being a good reason to remove it as
well.

Cc: Johan Hovold <johan@xxxxxxxxxx>
Cc: Alex Elder <elder@xxxxxxxxxx>
Cc: Jack Schofield <schofija@xxxxxxxxxxxxxxx>
Cc: Vaibhav Nagare <vnagare@xxxxxxxxxx>
Cc: greybus-dev@xxxxxxxxxxxxxxxx
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

That's a surprising amount of code.  And perhaps there
are better ways of exposing this type of information.
Anyway, no objection here.

Acked-by: Alex Elder <elder@xxxxxxxxxx>

---
  drivers/staging/greybus/tools/.gitignore      |   2 -
  drivers/staging/greybus/tools/Android.mk      |  10 -
  drivers/staging/greybus/tools/Makefile        |  33 -
  drivers/staging/greybus/tools/README.loopback | 198 ----
  drivers/staging/greybus/tools/lbtest          | 169 ---
  drivers/staging/greybus/tools/loopback_test.c | 979 ------------------
  6 files changed, 1391 deletions(-)
  delete mode 100644 drivers/staging/greybus/tools/.gitignore
  delete mode 100644 drivers/staging/greybus/tools/Android.mk
  delete mode 100644 drivers/staging/greybus/tools/Makefile
  delete mode 100644 drivers/staging/greybus/tools/README.loopback
  delete mode 100755 drivers/staging/greybus/tools/lbtest
  delete mode 100644 drivers/staging/greybus/tools/loopback_test.c





[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux