On Fri, Mar 24, 2023 at 08:28:50AM -0700, Alison Schofield wrote: > On Fri, Mar 24, 2023 at 12:20:30AM -0700, Sumitra Sharma wrote: > > Convert macros to a static inline function, to make the relevant > > types apparent in the definition and to benefit from the type > > checking performed by the compiler at call sites. > > > > CHanges in v2: Change patch subjects, noted by Alison Schofield > > > Please review: https://kernelnewbies.org/Outreachyfirstpatch > Section on 'Following the driver commit style'. > > To follow the commit style of the greybus driver, update these > commit messages to be under 80 chars, and use "staging", not > "Staging" > > Like this: > drivers/staging/greybus$ git log --oneline | head -3 > 1498054921e2 staging: greybus: Inline pwm_chip_to_gb_pwm_chip() > a7d2a41b7453 staging: greybus: Inline gb_audio_manager_module() > f7d3ece211be staging: greybus: Inline macro gpio_chip_to_gb_gpio_controller() > > BTW - I wasn't instantly sure about using 'Inline' as a verb in this > case, so I did this (git log --oneline | grep inline) and found it's > a common use. > > We're building a habit here for when you submit across subsystems > in the future. > Hi Alison, Thank you for helping me out with this patch subject. PS: I am focusing on writing good patch subjects and descriptions. Regards, Sumitra > Alison > > > > > Sumitra Sharma (3): > > Staging: greybus: Use inline function for macro > > gpio_chip_to_gb_gpio_controller > > Staging: greybus: Use inline function for gb_audio_manager_module > > Staging: greybus: Use inline function for pwm_chip_to_gb_pwm_chip > > > > drivers/staging/greybus/audio_manager_module.c | 7 +++++-- > > drivers/staging/greybus/gpio.c | 7 +++++-- > > drivers/staging/greybus/pwm.c | 6 ++++-- > > 3 files changed, 14 insertions(+), 6 deletions(-) > > > > -- > > 2.25.1 > > > >
