1: The subject doesn't have a patch prefix and is generally not in the
correct format.
On Thu, Mar 23, 2023 at 08:46:11PM +0100, Alexander Heinrich wrote:
> This patch fixes the following warning produced by checkpatch.pl,
> when run on drivers/staging/wlan-ng/p80211req.c.
>
> CHECK: Unnecessary parentheses around
> 'msg->msgcode != DIDMSG_DOT11REQ_MIBGET'
2: Add a blank line here, before the signed-off-by line.
> Signed-off-by: Alexander Heinrich <hallo@xxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/staging/wlan-ng/p80211req.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wlan-ng/p80211req.c b/drivers/staging/wlan-ng/p80211req.c
> index 809cf3d480e9..df2d07304d1c 100644
> --- a/drivers/staging/wlan-ng/p80211req.c
> +++ b/drivers/staging/wlan-ng/p80211req.c
> @@ -125,7 +125,7 @@ int p80211req_dorequest(struct wlandevice *wlandev, u8 *msgbuf)
>
> /* Check Permissions */
> if (!capable(CAP_NET_ADMIN) &&
> - (msg->msgcode != DIDMSG_DOT11REQ_MIBGET)) {
> + msg->msgcode != DIDMSG_DOT11REQ_MIBGET) {
3: Greg likes these parentheses so just ignore checkpatch on this.
(Don't resend this one, find something else to clean up).
regards,
dan carpenter
