On 3/21/23 4:29 PM, Julia Lawall wrote:
There do seem to be more than 100 definitions like: #define to_dove_clk(hw) container_of(hw, struct dove_clk, hw) where we have to hope that at all of the usage sites the argument is called hw. Probably anything else would cause a compiler error, but still it looks strange. julia
Yeah, that's poorly done and unfortunate. The argument to the parameter should be named something different. I didn't understand what you meant before but yes, this isn't good. These should be fixed first. -Alex