Re: [PATCH] staging: most: use inline functions for iface_to_hdm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On ٢٠‏/٣‏/٢٠٢٣ ١٧:٤٤, Greg KH wrote:
On Mon, Mar 20, 2023 at 12:33:35PM +0200, Menna Mahmoud wrote:
Convert `iface_to_hdm` macro into a static inline function.
it is not great to have macro that use `container_of` macro,
because from looking at the definition one cannot tell
what type it applies to.

One can get the same benefit from an efficiency point of view
by making an inline function.

Suggested-by: Julia Lawall <julia.lawall@xxxxxxxx>
Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@xxxxxxxxx>
---
  drivers/staging/most/dim2/dim2.c | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)
Your subject line has a "  " when it should have just a " " :(
I see, I will fix it.

Please fix up and send a v2.
I will.

thanks,

greg k-h

Thanks,

Menna





[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux