Re: [PATCH v2] Staging: nvec: Convert to_nvec_led from a macro to an inline function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Mon, 20 Mar 2023, Sumitra Sharma wrote:

> On Mon, Mar 20, 2023 at 08:39:49AM +0300, Dan Carpenter wrote:
> > On Sat, Mar 18, 2023 at 10:52:50AM -0700, Sumitra Sharma wrote:
> > > Convert to_nvec_led from a macro to a static inline function, to make the
> > > relevant types apparent in the definition and to benefit from the type
> > > checking performed by the compiler at call sites.
> > >
> > > Signed-off-by: Sumitra Sharma <sumitraartsy@xxxxxxxxx>
> > > ---
> >
> > You need to compile test your changes.
> >
>
> Hi dan,
>
> I am facing problems in creating modules and in compiling them.

Note that unless the code is under an ifdef for a module, you don't
specifically need the driver to be configured as for a module either.
Since you don't have the device, you aren't going to be able to test it
anyway.  So 'y' is fine.

julia

>
> Any help in this would be appreciated. Here is the link to the thread https://lore.kernel.org/outreachy/alpine.DEB.2.22.394.2303191336090.2867@hadrien/T/#t
>
> Regards,
>
> Sumitra
>
> > regards,
> > dan carpenter
> >
>
>




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux