On Wed, 15 Mar 2023, Menna Mahmoud wrote:
> add a space before and after the operator, for readability.
add -> Add
That is, start the sentence with a capital letter.
>
> Reported By checkpatch script:
By -> by
No need for capital letters in the middle of a sentence, unless you are
referring to a proper noun (name of someone or something).
julia
> " CHECK: spaces preferred around that '+', '<<' and '>>' ".
>
> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@xxxxxxxxx>
> ---
> change in v2:
> edit commit message
> ---
> change in v3:
> edit commit message
> ---
> drivers/staging/vme_user/vme_tsi148.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vme_user/vme_tsi148.c b/drivers/staging/vme_user/vme_tsi148.c
> index 482049cfc664..bfa604043355 100644
> --- a/drivers/staging/vme_user/vme_tsi148.c
> +++ b/drivers/staging/vme_user/vme_tsi148.c
> @@ -737,7 +737,7 @@ static int tsi148_alloc_resource(struct vme_master_resource *image,
> return 0;
>
> if (!image->bus_resource.name) {
> - image->bus_resource.name = kmalloc(VMENAMSIZ+3, GFP_ATOMIC);
> + image->bus_resource.name = kmalloc(VMENAMSIZ + 3, GFP_ATOMIC);
> if (!image->bus_resource.name) {
> retval = -ENOMEM;
> goto err_name;
> @@ -983,7 +983,7 @@ static int tsi148_master_set(struct vme_master_resource *image, int enabled,
> goto err_aspace;
> }
>
> - temp_ctl &= ~(3<<4);
> + temp_ctl &= ~(3 << 4);
> if (cycle & VME_SUPER)
> temp_ctl |= TSI148_LCSR_OTAT_SUP;
> if (cycle & VME_PROG)
> @@ -2187,14 +2187,14 @@ static int tsi148_crcsr_init(struct vme_bridge *tsi148_bridge,
>
> /* Ensure that the CR/CSR is configured at the correct offset */
> cbar = ioread32be(bridge->base + TSI148_CBAR);
> - cbar = (cbar & TSI148_CRCSR_CBAR_M)>>3;
> + cbar = (cbar & TSI148_CRCSR_CBAR_M) >> 3;
>
> vstat = tsi148_slot_get(tsi148_bridge);
>
> if (cbar != vstat) {
> cbar = vstat;
> dev_info(tsi148_bridge->parent, "Setting CR/CSR offset\n");
> - iowrite32be(cbar<<3, bridge->base + TSI148_CBAR);
> + iowrite32be(cbar << 3, bridge->base + TSI148_CBAR);
> }
> dev_info(tsi148_bridge->parent, "CR/CSR Offset: %d\n", cbar);
>
> --
> 2.34.1
>
>
>
