Khadija Kamran wrote: > In file drivers/staging/greybus/arche-platform.c, > - Length of line 181 exceeds 100 columns, fix by removing tabs from the > line. > - If condition and spin_unlock_...() call is split into two lines, join > them to form a single line. > > Signed-off-by: Khadija Kamran <kamrankhadijadj@xxxxxxxxx> Fundamentally the problem with arche_platform_wd_irq() is that the indentation is too great. "... if you need more than 3 levels of indentation, you’re screwed anyway, and should fix your program." -- https://www.kernel.org/doc/html/v4.10/process/coding-style.html#indentation I think a better solution would be to refactor the entire function. This would make the logic of the function more clear as well IMHO. Here is another tip to help: https://www.kernel.org/doc/html/v4.10/process/coding-style.html#centralized-exiting-of-functions Do you think you could try that? Ira > --- > Changes in v2: > - Change the subject and log message > - Merge if condition and spin_unlock...() from two lines to one > drivers/staging/greybus/arche-platform.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c > index fcbd5f71eff2..00ed5dfd7915 100644 > --- a/drivers/staging/greybus/arche-platform.c > +++ b/drivers/staging/greybus/arche-platform.c > @@ -176,12 +176,10 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid) > * Check we are not in middle of irq thread > * already > */ > - if (arche_pdata->wake_detect_state != > - WD_STATE_COLDBOOT_START) { > + if (arche_pdata->wake_detect_state != WD_STATE_COLDBOOT_START) { > arche_platform_set_wake_detect_state(arche_pdata, > - WD_STATE_COLDBOOT_TRIG); > - spin_unlock_irqrestore(&arche_pdata->wake_lock, > - flags); > + WD_STATE_COLDBOOT_TRIG); > + spin_unlock_irqrestore(&arche_pdata->wake_lock, flags); > return IRQ_WAKE_THREAD; > } > } > -- > 2.34.1 > >
