On Fri, Mar 10, 2023 at 08:59:17PM +0000, Archana wrote: > else block is not needed if j is set to -1 > before if block > > Signed-off-by: Archana <craechal@xxxxxxxxx> > --- Is Archana your full legal name that you would write on a legal document? I feel like the patch is nice and I like that it's based on reading the code instead of checkpatch. The commit message isn't great. Here is my suggestion on that: Subject: [PATCH 2/2] staging: wlan-ng: small clean up in plugimage() It's cleaner to set "j = -1;" before the if block and remove the else statement. The main differences are: 1: It says that the motivation for the patch is a clean up. 2: Capital letter at the start of the sentence. 3: Period at the end. I try not to be too picky about commit messages but the issue with your legal name is important so you were going to have to resend anyway. Also everyone can use capital letters and periods even if English is not their first language. We could figure out the motivation for the patch easily enough but we like to be extra strict with new people so they develop good habbits. regards, dan carpenter
