On Sun, Feb 26, 2023 at 09:25:00PM +0800, Kang Chen wrote: > kzalloc may fails, pdata_attr might be null and will cause > illegal address access later. > > Signed-off-by: Kang Chen <void0red@xxxxxxxxx> > --- > drivers/staging/r8188eu/core/rtw_p2p.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/r8188eu/core/rtw_p2p.c b/drivers/staging/r8188eu/core/rtw_p2p.c > index 93d3c9c43..802e1170a 100644 > --- a/drivers/staging/r8188eu/core/rtw_p2p.c > +++ b/drivers/staging/r8188eu/core/rtw_p2p.c > @@ -31,6 +31,8 @@ static u32 go_add_group_info_attr(struct wifidirect_info *pwdinfo, u8 *pbuf) > struct sta_priv *pstapriv = &padapter->stapriv; > > pdata_attr = kzalloc(MAX_P2P_IE_LEN, GFP_KERNEL); > + if (!pdata_attr) > + return 0; Return success here is not a good thing. We have to fix the caller to check for errors. (Fixing a bug half way just makes it harder to find the bug so it makes the situation worse). regards, dan carpenter
