On Tue, Feb 07, 2023 at 10:05:33AM +0100, Greg Kroah-Hartman wrote: > On Tue, Feb 07, 2023 at 09:40:37AM +0100, Guru Mehar Rachaputi wrote: > > This patch is to fix checkpatch warning: "Macro argument 'iobase' may be better > > as '(iobase)' to avoid precedence issues" changed to inline function. In > > relation to this, names of the callers of macro are also modified to call > > this function. > > > > > > Changes in v4: > > - Modified commit message to be clear > > > > Changes in v3: > > 1. Whitespace error from checkpatch fixed > > 2. Should be applied together with changes in v2 for testing > > > > Changes in v2: > > - Macros with one statement that is to call 'iowrite8' function changed > > to inline function as reviewed by gregkh@xxxxxxxxxxxxxxxxxxx. > > In relation to this, names of the callers of macro are also modified > > to call this function. > > > > > > Guru Mehar Rachaputi (4): > > staging: vt6655: Add braces to macro parameter 'iobase' > > staging: vt6655: Macro with braces issue change to inline function > > staging: vt6655: Macro with braces issue change to inline function > > staging: vt6655: Macro with braces issue changed to inline function > > > > drivers/staging/vt6655/card.c | 4 ++-- > > drivers/staging/vt6655/channel.c | 4 ++-- > > drivers/staging/vt6655/device_main.c | 12 ++++++------ > > drivers/staging/vt6655/mac.c | 8 ++++---- > > drivers/staging/vt6655/mac.h | 12 +++++++++--- > > 5 files changed, 23 insertions(+), 17 deletions(-) > > > > -- > > 2.34.1 > > > > > > -- > > Thanks & Regards, > > Guru > > > >From 447c10de599e3434fb6c012cdfc2cc8e4b5c839b Mon Sep 17 00:00:00 2001 > > Message-Id: <447c10de599e3434fb6c012cdfc2cc8e4b5c839b.1675753094.git.gurumeharrachaputi@xxxxxxxxx> > > In-Reply-To: <cover.1675753094.git.gurumeharrachaputi@xxxxxxxxx> > > References: <cover.1675753094.git.gurumeharrachaputi@xxxxxxxxx> > > From: Guru Mehar Rachaputi <gurumeharrachaputi@xxxxxxxxx> > > Date: Sat, 4 Feb 2023 04:34:38 +0100 > > Subject: [PATCH v2 1/4] staging: vt6655: Add braces to macro parameter > > 'iobase' > > <snip> > > Do you see other examples of people on the mailing list submitting > patches as multiple attachments? > > Please do not do this. > > I recommend taking a week or so and reviewing the other submissions that > are sent to the list first, to understand the processes involved, before > trying to submit your own changes. > > Remember, you need to learn to read first, before you learn how to write :) > > thanks, > > greg k-h Noted, Thank you. -- Thanks & Regards, Guru
