Re: [PATCH v2 0/4] staging: vt6655: Macro with braces issue changed to inline function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 07, 2023 at 08:40:23AM +0100, Greg Kroah-Hartman wrote:
> On Tue, Feb 07, 2023 at 08:14:26AM +0100, Guru Mehar Rachaputi wrote:
> > 
> > This patch is to fix checkpatch warning: "Macro argument 'iobase' may be better
> > as '(iobase)' to avoid precedence issues" changed to inline function. In
> > relation to this, names of the callers of macro are also modified to call
> > this function.
> > 
> > 
> > Changes in v4:
> > 	- Modified commit message to be clear
> > 
> > Changes in v3:
> > 	1. Whitespace error from checkpatch fixed
> > 	2. Should be applied together with changes in v2 for testing
> > 
> > Changes in v2:
> > 	- Macros with one statement that is to call 'iowrite8' function changed
> > 	to inline function as reviewed by gregkh@xxxxxxxxxxxxxxxxxxx.
> > 	In relation to this, names of the callers of macro are also modified
> > 	to call this function.
> > 
> > 
> > Guru Mehar Rachaputi (4):
> >   staging: vt6655: Add braces to macro parameter 'iobase'
> >   staging: vt6655: Macro with braces issue change to inline function
> >   staging: vt6655: Macro with braces issue change to inline function
> >   staging: vt6655: Macro with braces issue changed to inline function
> > 
> >  drivers/staging/vt6655/card.c        |  4 ++--
> >  drivers/staging/vt6655/channel.c     |  4 ++--
> >  drivers/staging/vt6655/device_main.c | 12 ++++++------
> >  drivers/staging/vt6655/mac.c         |  8 ++++----
> >  drivers/staging/vt6655/mac.h         | 12 +++++++++---
> >  5 files changed, 23 insertions(+), 17 deletions(-)
> > 
> > -- 
> > 2.34.1
> > 
> > 
> > -- 
> > Thanks & Regards,
> > Guru
> > 
> 
> I only see this 0/4 message, no actual patch in the series was sent out.
> Did something go wrong?
> 
> thanks,
> 
> greg k-h

Sorry, I sent another mail with all the patches.

--
Thanks & Regards,
Guru




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux