On Sun, Feb 05, 2023 at 04:34:29PM +0100, Nam Cao wrote: > On Sun, Feb 05, 2023 at 02:30:59PM +0100, Guru Mehar Rachaputi wrote: > > On Sun, Feb 05, 2023 at 02:16:07PM +0100, Greg Kroah-Hartman wrote: > > > On Sun, Feb 05, 2023 at 02:08:02PM +0100, Guru Mehar Rachaputi wrote: > > > > This patch is to fix checkpatch warning: "Macro argument 'iobase' may be better > > > > as '(iobase)' to avoid precedence issues" > > > > > > > > --- > > > > Changes in v3: > > > > - Whitespace error from checkpatch fixed > > > > > > > > Changes in v2: > > > > - Macros with one statement that is to call 'iowrite8' function changed > > > > to inline function as reviewed by gregkh@xxxxxxxxxxxxxxxxxxx. > > > > In relation to this, names of the callers of macro are also modified > > > > to call this function. > > > > > > > > Signed-off-by: Guru Mehar Rachaputi <gurumeharrachaputi@xxxxxxxxx> > > > > > > Try to take this patch and apply it to a tree, and see that everything > > > below the --- line is thrown away, including your signed-off-by: line :( > > > > > Sorry, should not a patch contain signed-off-by: line? > > I did not understand. > > Patches must include signed-off-by. However your patch has it below the > --- line, and git will throw it away. You can try "git am <your patch>" > and see for yourself. > > Best regards, > Nam Oh I see. Thanks for that. I changed it now. -- Thanks & Regards, Guru
