[ Resending because my email setup is crap and silently eats my out going mail. ] On Tue, Jan 31, 2023 at 10:00:57AM +0100, Martin Kaiser wrote: > Fix the NULL check for padapter->pnetdev->rx_handler_data. > > The current code calls rcu_dereference while it holds the rcu read lock > and checks the pointer after releasing the lock. An rcu pointer may only be > used between calls to rcu_read_lock and rcu_read_unlock. > > Replace the check with rcu_access_pointer. My understanding is that this > function returns the value of the pointer and needs no locking. We can > then check the pointer but we must not dereference it. > > Signed-off-by: Martin Kaiser <martin@xxxxxxxxx> This patch is fine but it's a clean up and not a fix. The original code doesn't dereference "br_port". I guess the new code is faster and especially if you have lockdep enabled, so maybe in that sense it is a fix. regards, dan carpenter
