On Mon, Jan 23, 2023 at 01:51:36PM +0100, Hans de Goede wrote: > The following drivers under drivers/media/i2c: ov08x40.c, ov13858.c, > ov13b10.c, ov2680.c, ov2685.c, ov2740.c, ov4689.c, ov5670.c, > ov5675.c, ov5695.c, ov8856.c, ov9282.c and ov9734.c, > > as well as various "atomisp" sensor drivers in drivers/staging, *all* > use register access helpers with the following function prototypes: > > int ovxxxx_read_reg(struct ovxxxx_dev *sensor, u16 reg, > unsigned int len, u32 *val); > > int ovxxxx_write_reg(struct ovxxxx_dev *sensor, u16 reg, > unsigned int len, u32 val); > While reviewing the following patch, I realize that we actually don't need these long names. int ov_read_reg(struct ovxxxx_dev *sensor, u16 reg, unsigned int len, u32 *val); int ov_write_reg(struct ovxxxx_dev *sensor, u16 reg, unsigned int len, u32 val); will work fine and fit one line (80 limit). -- With Best Regards, Andy Shevchenko
