On Thu, 19 Jan 2023 at 14:37, Dan Carpenter <error27@xxxxxxxxx> wrote: > > On Thu, Jan 19, 2023 at 02:31:50PM +0000, Phil Elwell wrote: > > On Thu, 19 Jan 2023 at 14:25, Dan Carpenter <error27@xxxxxxxxx> wrote: > > > > > > On Thu, Jan 19, 2023 at 01:47:44PM +0000, Phil Elwell wrote: > > > > > > I understand the desire to remove the custom logging. I don't welcome > > > > > > the loss of flexibility that comes with such a strategy > > > > > > > > > > What "loss of flexibility"? You now have access to the full dynamic > > > > > debugging facilities that all of the rest of the kernel has. What is > > > > > lacking? > > > > > > > > Perhaps I've missed something, either in this patch set or the kernel > > > > as a whole, but how is one supposed to set different logging levels on > > > > different facilities within a driver/module, or even for the module as > > > > a whole? > > > > > > Yeah. You will be still able to do that and more besides after the > > > transition. Cleaning this up makes the code better in every way. > > > > > > Documentation/admin-guide/dynamic-debug-howto.rst > > > > Are you saying this patch set gets us to that point? > > Yes. The patch has some issues, but yes. OK, thanks. I'll be watching how this plays out with interest. Phil
