On Wed, Jan 18, 2023 at 05:28:06PM +0530, Umang Jain wrote: > Drop custom logging from the vchiq interface. > Mostly of them are replaced with dev_dbg and friends > and/or pr_info and friends. Everything should be dev_*() calls, there should never be a pr_* call in a driver. > The debugfs log levels (in 4/4) are mapped to kernel > logs levels (coming from include/linux/kern_levels.h) > Would like some thoughts on it as I am not sure (hence > marking this is RFC) Do not have any "custom" debugging controls in a driver, they are not special and should follow the whole rest of the kernel. Just remove them all and rely on the existing dev_*() calls instead please. thanks, greg k-h
