On Thu, Jan 12, 2023 at 11:55:07AM -0300, Ezequiel Garcia wrote: > Hi Sebastian, > > On Thu, Jan 12, 2023 at 9:56 AM Sebastian Fricke > <sebastian.fricke@xxxxxxxxxxxxx> wrote: > > > > Ensure that both the CAPTURE and the OUTPUT queue are running (e.g. busy > > -> have buffers allocated) before starting the actual streaming process. > > > > Usually, you want to write the "why" in the commit description, > instead of the "what", > which is (hopefully) more or less clear by reading the commit change. > > The commit description should have enough information to understand > what is the impact of merging the commit (or what is the bug without > the merging the commit). > > If you are fixing a spec violation, adding a reference to the spec is important, > if you are fixing a v4l2-compliance, pasting the error, etc. > Yeah, and if it's a bug fix then add a Fixes tag as well. Even if the bug was added when the driver was first merged, that's still useful information. regards, dan carpenter
