Re: [PATCH] staging: greybus: codecs: Drop empty platform remove function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/12/22 4:13 PM, Uwe Kleine-König wrote:
A remove callback just returning 0 is equivalent to no remove callback
at all. So drop the useless function.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

I agree, this looks good to me.

Reviewed-by: Alex Elder <elder@xxxxxxxxxx>

---
  drivers/staging/greybus/audio_codec.c | 6 ------
  1 file changed, 6 deletions(-)

diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
index 0ad8aeabccbf..72ace74ea605 100644
--- a/drivers/staging/greybus/audio_codec.c
+++ b/drivers/staging/greybus/audio_codec.c
@@ -1075,11 +1075,6 @@ static int gbaudio_codec_probe(struct platform_device *pdev)
  			gbaudio_dai, ARRAY_SIZE(gbaudio_dai));
  }
-static int gbaudio_codec_remove(struct platform_device *pdev)
-{
-	return 0;
-}
-
  static const struct of_device_id greybus_asoc_machine_of_match[]  = {
  	{ .compatible = "toshiba,apb-dummy-codec", },
  	{},
@@ -1094,7 +1089,6 @@ static struct platform_driver gbaudio_codec_driver = {
  		.of_match_table = greybus_asoc_machine_of_match,
  	},
  	.probe = gbaudio_codec_probe,
-	.remove = gbaudio_codec_remove,
  };
  module_platform_driver(gbaudio_codec_driver);
base-commit: 830b3c68c1fb1e9176028d02ef86f3cf76aa2476





[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux