On Sun, Dec 11, 2022 at 12:06:04PM +0100, Greg Kroah-Hartman wrote: > On Sun, Dec 11, 2022 at 11:56:49AM +0100, Dalvin Aiguobas wrote: > > Checkpatch Styleproblem fixed by adding comment. > > > > Signed-off-by: Dalvin <pharcodra@xxxxxxxxx> > > --- > > drivers/staging/wlan-ng/hfa384x.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h > > index 0611e37df6ac..ad117d570bb6 100644 > > --- a/drivers/staging/wlan-ng/hfa384x.h > > +++ b/drivers/staging/wlan-ng/hfa384x.h > > @@ -1171,6 +1171,7 @@ struct hfa384x_usbctlx { > > }; > > > > struct hfa384x_usbctlxq { > > + /* lock: Protect structure fields */ Also, does this comment really make sense? To properly document a lock takes a bit more text, if you read this would it help out in understanding the code any? thanks, greg k-h