Hello Rob, On Thu, 1 Dec 2022 17:16:36 -0600 Rob Herring <robh@xxxxxxxxxx> wrote: > On Mon, Nov 28, 2022 at 04:23:17PM +0100, Luca Ceresoli wrote: > > The Tegra20 VI peripheral can receive parallel input from the VIP parallel > > input module. Add it to the allowed properties and augment the existing > > nvidia,tegra20-vi example to show a 'vip' property. > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > Signed-off-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx> > > > > --- > > > > Changed in v2 (suggested by Krzysztof Kozlowski): > > - rename "i2c3" -> "ic2" > > - add review tag > > --- > > .../display/tegra/nvidia,tegra20-vi.yaml | 68 +++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 69 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml > > index 782a4b10150a..5b5583c2b562 100644 > > --- a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml > > +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml > > @@ -74,6 +74,22 @@ properties: > > avdd-dsi-csi-supply: > > description: DSI/CSI power supply. Must supply 1.2 V. > > > > + vip: > > + $ref: /schemas/display/tegra/nvidia,tegra20-vip.yaml > > + > > + ports: > > + $ref: /schemas/graph.yaml#/properties/ports > > + > > + properties: > > + port@0: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: > > + Input from the VIP (parallel input capture) module > > + > > + properties: > > + endpoint: > > + $ref: /schemas/graph.yaml#/properties/endpoint > > You can drop 'endpoint'. You only need port nodes if there's no extra > properties in the endpoints. Oh, nice, will remove in v3. Krzysztof, can I keep your Reviewed-by after this change? -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
