On Tue, Nov 22, 2022 at 01:08:31PM +0100, Greg Kroah-Hartman wrote: > On Sat, Nov 19, 2022 at 10:41:17PM +0530, Deepak R Varma wrote: > > Value for the LNA gain is captured from the user as part of the struct > > pi433_rx_cfg, however, the corresponding function rf69_set_lna_gain() is > > never called to set it. Include a call to this function as part of > > setting up the rx configurations. > > > > Signed-off-by: Deepak R Varma <drv@xxxxxxxxx> > > --- > > drivers/staging/pi433/pi433_if.c | 3 +++ > > 1 file changed, 3 insertions(+) > > How was this change tested? Hi Greg, This was compile tested only. As per your message on the other patch for this driver, I am holding back such patches until I have the ability to test the change with a real device myself. I most welcome if there is any other feedback on the patches. It will help me consolidate the feedback and react to them in one go. Thank you, ./drv > > thanks, > > greg k-h >
