Hi, On 11/14/22 13:22, Andy Shevchenko wrote: > On Thu, Oct 20, 2022 at 09:55:16PM +0200, Hans de Goede wrote: >> Hi All, >> >> Here is v2 of my patch series converting the staging atomisp driver to use >> the videobuf2 framework, fixing MMAP mode not working. >> >> New in v2 is that the "media: atomisp: Convert to videobuf2" patch >> now also contains moving over to using a per vb_queue lock as is >> standard for v4l2 drivers. This removes a bunch of FIXME + checkpatch >> warnings (due to commented out prep for this) from v1 of this patch. >> This v2 also fixes the 1 new warning pointed out by the lkp test robot. >> >> For some more background info here are the still relevant bits of >> the v1 cover-letter: >> >> This also contains an important fix to try_fmt handling, so that >> the various supported output formats can actually be used by userspace >> which calls try_fmt before doing s_fmt. >> >> So slowly this is starting to look more and more like a standard >> v4l2 device (with all the complex pipeline handling hidden in the driver, >> moving that to userspace seems to be impossible with this design since >> multiple pipeline steps are handled by a single firmware program). > > I completely in favour of the series, so > Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx> > for non-commented patches, for the commented, where comment is a "side note". > > For the rest depends on your action, if you are going to address as suggested, > feel free to add my tag. Thanks, I've pushed an updated version with your suggested changes and your Reviewed-by added to my media-atomisp branch in preparation for sending a pull-req to Mauro with these changes. I'll also add your patch "[PATCH v1 1/1] atomisp: Make bds_factors_list be type of struct u32_fract" there once I have had the time to review it. Note since I send out this series I've been working on a bunch of further cleanups / on preparation work for getting rid of the ugly PCI power-management errors on (runtime)suspend/resume. I will send these out as a patch series now and I've also pushed these to my media-atomisp branch. Regards, Hans
