Re: [PATCH v2 04/17] media: atomisp: On streamoff wait for buffers owned by the CSS to be given back

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 20, 2022 at 09:55:20PM +0200, Hans de Goede wrote:
> There is no guarantee that when we stop the pipeline all buffers owned
> by the CSS are cleanly returned to the videobuf queue.
> 
> This is a problem with videobuf2 which will complain loudly when not
> all buffers have been returned after the streamoff() queue op has
> returned.
> 
> And this also allows moving a WARN() in the continuous mode path.

...

> +	if (ret <= 0)
> +		return ret ? ret : -ETIME;

You can use Elvis and ETIME is not correct AFAIU, should be -ETIMEDOUT.


-- 
With Best Regards,
Andy Shevchenko






[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux