On Wed, Nov 09, 2022 at 08:30:26AM +0100, Greg Kroah-Hartman wrote: > On Wed, Nov 09, 2022 at 11:26:52AM +0530, Deepak R Varma wrote: > > The show() methods should only use sysfs_emit() when formatting values > > to be returned to the user space. > > Ref: Documentation/filesystems/sysfs.rst > > Issue identified by coccicheck. > > > > Signed-off-by: Deepak R Varma <drv@xxxxxxxxx> > > /* > > - * card_name was provided by child driver, could potentially be long. > > - * protect against buffer overrun. > > + * sysfs provides PAGE_SIZE long buffer to take care of potentially > > No need to ever mention PAGE_SIZE at all, this comment should just be: > /* card_name was provided by child driver */ Sure. I will update the comment in the revision. > > But the larger question is, why did you only convert one of the sysfs > show functions in this file? Why not do them all? I was limiting it to what is reported by coccicheck. I will review other such show functions and send a consolidated patch. Thank you, ./drv > > thanks, > > greg k-h >
