On Sun, Nov 06, 2022 at 04:34:57PM +0100, Michael Straube wrote: > On 11/6/22 15:35, Deepak R Varma wrote: > > On Sun, Nov 06, 2022 at 02:34:43PM +0100, Michael Straube wrote: > > > Convert the error handling in the function rtw_start_drv_threads() to > > > the common logic used in the kernel. Another step to get rid of _FAIL > > > and _SUCCESS which uses inverted logic. > > > > Hello Michael, > > Can you please tell how did you find this opportunity for improvement? Are you > > using some tool or is it a manual code review/analysis? > > > > Hi Deepak, > > I just used git grep to search for _FAIL or _SUCCESS and then looked at > the code manually. > > Regards, > Michael > Okay. That is very helpful. Thank you Michael. ./drv
