On Thu, Nov 03, 2022 at 12:49:38AM +0530, Deepak R Varma wrote: > I am wondering if ijk_matrix_regs_set (or IQKMatrixRegSetting) is a one element > array, why is it declared as a two dimensional array? Can this be a simple one > dimensional array instead? Is this the cleanup you are referring to when you say > "code is messy and should be cleaned up"? Yes. You have interpreted that correctly. regards, dan carpenter