On Mon, Oct 31, 2022 at 10:25:15AM -0400, drake@xxxxxxxxxxxxxxx wrote: > From: Drake Talley <drake@xxxxxxxxxxxxxxx> > > Since msleep may delay for up to 20ms, usleep_range is recommended for > short durations in the docs linked in the below warning. I set the > range to 1000-2000 based on looking at other usages of usleep_range. > > Reported by checkpatch: > > WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst > > Signed-off-by: Drake Talley <drake@xxxxxxxxxxxxxxx> > --- > drivers/staging/qlge/qlge_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c > index 8c1fdd8ebba0..c8403dbb5bad 100644 > --- a/drivers/staging/qlge/qlge_main.c > +++ b/drivers/staging/qlge/qlge_main.c > @@ -3890,7 +3890,7 @@ static int qlge_close(struct net_device *ndev) > * (Rarely happens, but possible.) > */ > while (!test_bit(QL_ADAPTER_UP, &qdev->flags)) > - msleep(1); > + usleep_range(1000, 2000); Please see the mailing list archives for why making this type of change without the hardware to test it is not a good idea. sorry, greg k-h
