well for the start it was not giving an error but after fixing blank lines that is when i saw that Thank you for the hint i fixed it On Thu, 27 Oct 2022 at 10:56, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > On Wed, Oct 26, 2022 at 07:14:34PM +0200, Nam Cao wrote: > > On Wed, Oct 26, 2022 at 04:28:38PM +0300, UMWARI JOVIAL wrote: > > > Using the checkpatch.pl script, found the below errors and fixed > > > ERROR: trailing whitespace > > > CHECK: Please don't use multiple blank lines > > > warning: braces around scalar initializer > > > > > > Signed-off-by: UMWARI JOVIAL <umwarijovial@xxxxxxxxx> > > > --- > > > drivers/staging/most/dim2/dim2.c | 2 -- > > > 1 file changed, 2 deletions(-) > > > > > > diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c > > > index 7a5f80e637a0..28259ce05024 100644 > > > --- a/drivers/staging/most/dim2/dim2.c > > > +++ b/drivers/staging/most/dim2/dim2.c > > > @@ -987,7 +987,6 @@ static int rcar_gen2_enable(struct platform_device *pdev) > > > writel(0x04, dev->io_base + 0x600); > > > } > > > > > > - > > > /* BBCR = 0b11 */ > > > writel(0x03, dev->io_base + 0x500); > > > writel(0x0002FF02, dev->io_base + 0x508); > > > @@ -1084,7 +1083,6 @@ static const struct of_device_id dim2_of_match[] = { > > > { > > > .compatible = "xlnx,axi4-os62420_6pin-1.00.a", > > > }, > > > - {}, > > > > I'm no expert, but this looks like a null terminator and probably > > should not be removed. > > You're absolutely correct. Also I tried to see why checkpatch.pl was > printing an error for this but it doesn't print an error for me. > > regards, > dan carpenter >