On Wed, Oct 26, 2022 at 03:14:23PM +0200, Greg Kroah-Hartman wrote: > On Wed, Oct 26, 2022 at 08:58:44AM +0530, Deepak R Varma wrote: > > Pre-processor macros that are defined but are never used should be > > cleaned up to avoid unexpected usage. > > > > Signed-off-by: Deepak R Varma <drv@xxxxxxxxx> > > --- > > drivers/staging/rtl8192u/ieee80211/ieee80211.h | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging/rtl8192u/ieee80211/ieee80211.h > > index 00c07455cbb3..0b3dda59d7c0 100644 > > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211.h > > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211.h > > @@ -230,8 +230,6 @@ struct cb_desc { > > #define ieee80211_unregister_crypto_ops ieee80211_unregister_crypto_ops_rsl > > #define ieee80211_get_crypto_ops ieee80211_get_crypto_ops_rsl > > > > -#define ieee80211_ccmp_null ieee80211_ccmp_null_rsl > > - > > #define free_ieee80211 free_ieee80211_rsl > > #define alloc_ieee80211 alloc_ieee80211_rsl > > These #defines are a mess, please look into unwinding them as they > should not be needed at all. Hello Greg, I would like to know what you mean by "unwind them". Is there a documentation or past commit that I can review to understand the expectations better? Thank you, ./drv > > thanks, > > greg k-h >