Re: [PATCH 02/17] staging: vt6655: changed variable names: s_vFillRTSHead

Philipp Hortmann <philipp.g.hortmann@xxxxxxxxx> · Wed, 26 Oct 2022 04:56:43 +0200

On 10/26/22 01:36, Tanjuate Brunostar wrote:
     change variable names s_vFillRTSHead and wTimeStampOff to meet the
     linux coding standard, as it says to avoid using camelCase naming style.
     Cought by checkpatch

WARNING: Possible unwrapped commit description (prefer a maximum 75 
chars per line)
#8:
    linux coding standard, as it says to avoid using camelCase naming 
style.

You need to use checkpatch on your patches before you send them in.

Bye Philipp



Signed-off-by: Tanjuate Brunostar <tanjubrunostar0@xxxxxxxxx>
---
  drivers/staging/vt6655/rxtx.c | 54 +++++++++++++++++------------------
  1 file changed, 27 insertions(+), 27 deletions(-)

diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
index ac9b3402be4f..8bb06b142748 100644
--- a/drivers/staging/vt6655/rxtx.c
+++ b/drivers/staging/vt6655/rxtx.c
@@ -23,7 +23,7 @@
   *      s_uGetTxRsvTime- get frame reserved time
   *      s_vFillCTSHead- fulfill CTS ctl header
   *      s_vFillFragParameter- Set fragment ctl parameter.
- *      s_vFillRTSHead- fulfill RTS ctl header
+ *      s_v_fill_rts_head- fulfill RTS ctl header
   *      s_vFillTxKey- fulfill tx encrypt key
   *      s_vSWencryption- Software encrypt header
   *      vDMA0_tx_80211- tx 802.11 frame via dma0
@@ -54,7 +54,7 @@
   */
  #define CRITICAL_PACKET_LEN      256
  
-static const unsigned short wTimeStampOff[2][MAX_RATE] = {
+static const unsigned short w_time_stamp_off[2][MAX_RATE] = {
  	{384, 288, 226, 209, 54, 43, 37, 31, 28, 25, 24, 23}, /* Long Preamble */
  	{384, 192, 130, 113, 54, 43, 37, 31, 28, 25, 24, 23}, /* Short Preamble */
  };
@@ -85,15 +85,15 @@ static const unsigned short w_fb_opt_1[2][5] = {
  #define DATADUR_A_F1    13
  
  /*---------------------  Static Functions  --------------------------*/
-static void s_vFillRTSHead(struct vnt_private *pDevice,
-			   unsigned char byPktType,
-			   void *pvRTS,
-			   unsigned int	cbFrameLength,
-			   bool bNeedAck,
-			   bool bDisCRC,
-			   struct ieee80211_hdr *hdr,
-			   unsigned short wCurrentRate,
-			   unsigned char byFBOption);
+static void s_v_fill_rts_head(struct vnt_private *pDevice,
+			      unsigned char byPktType,
+			      void *pvRTS,
+			      unsigned int	cbFrameLength,
+			      bool bNeedAck,
+			      bool bDisCRC,
+			      struct ieee80211_hdr *hdr,
+			      unsigned short wCurrentRate,
+			      unsigned char byFBOption);
  
  static void s_vGenerateTxParameter(struct vnt_private *pDevice,
  				   unsigned char byPktType,
@@ -130,7 +130,7 @@ static __le16 s_uFillDataHead(struct vnt_private *pDevice,
  
  static __le16 vnt_time_stamp_off(struct vnt_private *priv, u16 rate)
  {
-	return cpu_to_le16(wTimeStampOff[priv->preamble_type % 2]
+	return cpu_to_le16(w_time_stamp_off[priv->preamble_type % 2]
  							[rate % MAX_RATE]);
  }
  
@@ -620,15 +620,15 @@ static __le16 s_uFillDataHead(struct vnt_private *pDevice,
  	return buf->duration;
  }
  
-static void s_vFillRTSHead(struct vnt_private *pDevice,
-			   unsigned char byPktType,
-			   void *pvRTS,
-			   unsigned int cbFrameLength,
-			   bool bNeedAck,
-			   bool bDisCRC,
-			   struct ieee80211_hdr *hdr,
-			   unsigned short wCurrentRate,
-			   unsigned char byFBOption)
+static void s_v_fill_rts_head(struct vnt_private *pDevice,
+			      unsigned char byPktType,
+			      void *pvRTS,
+			      unsigned int cbFrameLength,
+			      bool bNeedAck,
+			      bool bDisCRC,
+			      struct ieee80211_hdr *hdr,
+			      unsigned short wCurrentRate,
+			      unsigned char byFBOption)
  {
  	unsigned int uRTSFrameLen = 20;
  
@@ -977,8 +977,8 @@ static void s_vGenerateTxParameter(struct vnt_private *pDevice,
  								pDevice->byTopCCKBasicRate,
  								bNeedACK);
  
-			s_vFillRTSHead(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC,
-				       psEthHeader, wCurrentRate, byFBOption);
+			s_v_fill_rts_head(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC,
+					  psEthHeader, wCurrentRate, byFBOption);
  		} else {/* RTS_needless, PCF mode */
  			struct vnt_rrv_time_cts *buf = pvRrvTime;
  
@@ -1004,8 +1004,8 @@ static void s_vGenerateTxParameter(struct vnt_private *pDevice,
  							      wCurrentRate, bNeedACK);
  
  			/* Fill RTS */
-			s_vFillRTSHead(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC,
-				       psEthHeader, wCurrentRate, byFBOption);
+			s_v_fill_rts_head(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC,
+					  psEthHeader, wCurrentRate, byFBOption);
  		} else if (!pvRTS) {/* RTS_needless, non PCF mode */
  			struct vnt_rrv_time_ab *buf = pvRrvTime;
  
@@ -1022,8 +1022,8 @@ static void s_vGenerateTxParameter(struct vnt_private *pDevice,
  							      wCurrentRate, bNeedACK);
  
  			/* Fill RTS */
-			s_vFillRTSHead(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC,
-				       psEthHeader, wCurrentRate, byFBOption);
+			s_v_fill_rts_head(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC,
+					  psEthHeader, wCurrentRate, byFBOption);
  		} else { /* RTS_needless, non PCF mode */
  			struct vnt_rrv_time_ab *buf = pvRrvTime;
  








