On Mon, Oct 24, 2022 at 08:23:08PM +0900, Kang Minchul wrote: > 2022년 10월 24일 (월) 오후 5:49, Kang Minchul <tegongkang@xxxxxxxxx>님이 작성: > > > > This patch series cleans up unused variables in r8188eu > > causing coccicheck warnings. > > > > Difference between v1 and this patch is that this patch series > > include making function amsdu_to_msdu in /r8188eu/core/rtw_recv.c > > into void function. > > > > Kang Minchul (4): > > staging: r8188eu: remove unnecessary variable in ioctl_linux > > staging: r8188eu: make amsdu_to_msdu void function > > staging: r8188eu: remove unnecessary variable in rtl8188eu_xmit > > staging: r8188eu: remove unnecessary variable in rtw_ap > > > > drivers/staging/r8188eu/core/rtw_ap.c | 5 ++--- > > drivers/staging/r8188eu/core/rtw_recv.c | 5 +---- > > drivers/staging/r8188eu/hal/rtl8188eu_xmit.c | 3 +-- > > drivers/staging/r8188eu/os_dep/ioctl_linux.c | 4 +--- > > 4 files changed, 5 insertions(+), 12 deletions(-) > > > > -- > > 2.34.1 > > > Oh, I guess patch 4/4 can be fixed as well. > I think the function rtw_sta_flush can be void as well. > > I'll resend the patch later. You broke the build in this series, please fix up and send a v3. thanks, greg k-h